Skip to content

chore: remove bls flag and some getter#947

Merged
karim-en merged 2 commits intomasterfrom
remove-bls-flag
Jun 2, 2025
Merged

chore: remove bls flag and some getter#947
karim-en merged 2 commits intomasterfrom
remove-bls-flag

Conversation

@karim-en
Copy link
Copy Markdown
Collaborator

@karim-en karim-en commented Jun 2, 2025

  • Bump the contract version to 0.6.0
  • Removed the bls feature flag
  • Removed some getters and combined themm into one get_config

@karim-en karim-en requested review from a team and r-near June 2, 2025 22:17
Copy link
Copy Markdown
Contributor

@frolvanya frolvanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that cargo-near is used in this project, so why do we still keep contract wasm in a res folder? Should I add a workflow to build contracts and put them to releases?

Comment thread contracts/near/eth2-client/Cargo.toml Outdated
Comment thread contracts/near/eth2-client/src/lib.rs
@karim-en
Copy link
Copy Markdown
Collaborator Author

karim-en commented Jun 2, 2025

I see that cargo-near is used in this project, so why do we still keep contract wasm in a res folder? Should I add a workflow to build contracts and put them to releases?

Yeh, we need to add workflow.
The binary was submitted because the CI hasn't configured yet

@frolvanya
Copy link
Copy Markdown
Contributor

@karim-en added in #948

Copy link
Copy Markdown
Contributor

@frolvanya frolvanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix CI in this PR?

@karim-en karim-en merged commit 22f3db8 into master Jun 2, 2025
17 of 21 checks passed
@karim-en karim-en deleted the remove-bls-flag branch June 2, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants