fix: bump eth2near Rust version to 1.86.0#960
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust version in the eth2near Dockerfile from 1.84.0 to 1.86.0 to support the alloy-primitives v1.2.0 dependency, which requires edition2024 (stable in Rust 1.85+).
Key changes:
- Bump Docker base image from
rust:1.84.0-bookwormtorust:1.86.0-bookworm
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,5 +1,5 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| FROM rust:1.84.0-bookworm AS builder | |||
| FROM rust:1.86.0-bookworm AS builder | |||
There was a problem hiding this comment.
The Rust version is being updated in the Dockerfile, but the corresponding eth2near/rust-toolchain file still specifies version 1.84.0. Both files should be updated to ensure consistency between local development (which uses rust-toolchain) and Docker builds. Please also update the channel in eth2near/rust-toolchain from "1.84.0" to "1.86.0".
Suggested change
| FROM rust:1.86.0-bookworm AS builder | |
| FROM rust:1.84.0-bookworm AS builder |
karim-en
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alloy-primitives v1.2.0 requires edition2024, which is only stable in Rust 1.85+