看看有没有什么要改进的#365
Closed
liuliuliu0127 wants to merge 57 commits into
Closed
Conversation
…从建造者模式改成了直接方法调用，根据这个修复合并后的冲突
slmpc
reviewed
Jul 3, 2026
Collaborator
There was a problem hiding this comment.
添加ColorListSetting能在什么地方用到吗，我认为这个Setting是不需要的
Collaborator
There was a problem hiding this comment.
不要移除现有的注释，或者可以将其翻译为中文，但是不要移除这里的JavaDoc
| Screen screen = mc.screen; | ||
| if (screen != null) { | ||
| mc.onTextInputFocusChange(screen, true); | ||
| refCount++; |
Collaborator
There was a problem hiding this comment.
对于这里大量的重复代码，我认为需要进行抽象来简化和增强可维护性，而不是复制粘贴多次。
这里大量重复代码指的是多个集合Setting的Widget，我认为这里可以把基类命名为AbstractSetSettingWidget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目前部分list类设置还没有popup二级菜单，而且二级菜单已知在单窗口式模式下打开以后有时会导致clickgui背景颜色闪烁。
关闭这个pullrequest之前请明确告知原因