Skip to content

Revert "Fix @alias test on nightly (#1612)"#1716

Open
lgoettgens wants to merge 1 commit into
Nemocas:masterfrom
lgoettgens:lg/revert-1612
Open

Revert "Fix @alias test on nightly (#1612)"#1716
lgoettgens wants to merge 1 commit into
Nemocas:masterfrom
lgoettgens:lg/revert-1612

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

Reverts #1612.

The underlying issue has been fixed in JuliaLang/julia#54499 and should be available in tomorrows nightly and 1.11.0-beta2.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.42%. Comparing base (6b230ed) to head (00bf708).
⚠️ Report is 541 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1716      +/-   ##
==========================================
+ Coverage   87.35%   87.42%   +0.06%     
==========================================
  Files         117      117              
  Lines       29824    30066     +242     
==========================================
+ Hits        26053    26284     +231     
- Misses       3771     3782      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma thofma closed this May 29, 2024
@thofma thofma reopened this May 29, 2024
@thofma
Copy link
Copy Markdown
Member

thofma commented May 29, 2024

Which tomorrow did you mean?

@lgoettgens
Copy link
Copy Markdown
Member Author

The failure seems to have changed. I need to investigate further

@lgoettgens
Copy link
Copy Markdown
Member Author

JuliaLang/julia#54499 is only semi fixing this, see JuliaLang/julia#54664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants