-
Notifications
You must be signed in to change notification settings - Fork 73
Adding new functions rank_interpolation, rank_interpolation_mc and evaluation_points. #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I'll review this. |
lgoettgens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave the mathematics to Tommy, but here are some technical things
thofma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks. I left a few comments that should be addressed. There are also a few general things:
- The indentation should be consistent. At the moment it is 3 spaces, 4 spaces or 6 spaces.
- Make the spaces after the comma consistent. So it should be
M[i, j]instead ofM[i,j]etc. - The files should have a new line at the end. (We can discuss in person what does means or why your editor does not do this automatically.)
- No unicode (aka
ϵ).
Co-authored-by: Tommy Hofmann <[email protected]>
|
Thanks for reviewing @thofma @lgoettgens. I have applied all your suggestions. |
|
Needs a few changes. If you are done, you can mark the PR as "ready for review" (there is a button for this near the end of the page). |
|
There are still 2 problems @thofma:
|
|
Before fixing the |
rank_interpolation_mc is a monte-carlo version of rank_interpolation. Both functions were written for matrices over rational function field / polynomial rings, since in this case llu decomposition is slow.
evaluation_points returns the needed points from the base field for "interpolation".