docs: add PDF versions of SVG diagrams#2324
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
- Coverage 88.16% 88.15% -0.01%
==========================================
Files 126 126
Lines 32047 32047
==========================================
- Hits 28253 28252 -1
- Misses 3794 3795 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not yet build a PDF manual, but makes us ready for that.
The actual conversion shall be implemented by @various in PR #2307, which will have to be rebased once this PR here is in. He can then worry about details like how we can enable/disable building the PDF, integrating it into the CI, etc.
Also, this PR should help @varuntrehan7 figure out how to deal with the SVGs in Nemo.jl
Note that many tools for converting SVG to PDF don't cut it (e.g. Cairo's svg2pdf, or inkscape, etc.). The only general purpose SVG renders I am aware of are web browsers. E.g. the SVGs in this repo use a blur effect for shadows...
One can use a site like https://jsontotable.org/svg-to-pdf to do the conversion.