Skip to content

Remove zeros(::ZZPolyRingElem) #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fingolfin wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove zeros(::ZZPolyRingElem) #2228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/HeckeMoreStuff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,26 +744,6 @@ function (R::QQPolyRing)(a::Generic.RationalFunctionFieldElem{QQFieldElem})
return R(numerator(a))
end

@doc raw"""
zeros(f::ZZPolyRingElem) -> Vector{ZZRingElem}

Computes the integer zeros of a given polynomial $f$.
"""
function zeros(f::ZZPolyRingElem)

fac = factor(f)
zeros = ZZRingElem[]

# check if there are monic linear factors <-> zeros
for i in fac
if degree(i[1]) == 1 && leading_coefficient(i[1]) == 1
push!(zeros, -coeff(i[1], 0))
end
end

return zeros
end

function lift!(x::fpFieldElem, z::ZZRingElem)
set!(z, x.data)
return z
Expand Down
Loading