Add nf_elem_to_poly! helper
#2232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a "missing" coercion from AbsSimpleNumFieldElem to FpPolyRingElem. These functions are used in Hecke. Once Hecke switched to the new names, the old ones could be deprecated/removed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2232 +/- ##
==========================================
- Coverage 88.38% 88.38% -0.01%
==========================================
Files 100 100
Lines 37170 37178 +8
==========================================
+ Hits 32852 32858 +6
- Misses 4318 4320 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Can we remove them later? We would also need to cook up a new name for the |
Member
Author
|
Sure, I am not in a hurry to remove those -- I was just adding the "missing" method out of reflex, and then started to think WTF am I doing here 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a "missing" coercion from
AbsSimpleNumFieldElemtoFpPolyRingElem.But considering the work @thofma just went through to get rid of a bunch of non-"canonical" coercions, perhaps instead of adding this one, the other three should be removed?
(I don't know if anything uses these... would need upstream tests to know)
Note that the functions
nf_elem_to_gfp_fmpz_poly!etc. are used in Hecke. Once Hecke switched to the new namenf_elem_to_poly!, the old names could be deprecated/removed.