Skip to content

3990 tipo producto rental business#1762

Merged
NeoRazorX merged 5 commits intoNeoRazorX:masterfrom
daniel89fg:3990-tipo-producto-rental-business
Jul 23, 2025
Merged

3990 tipo producto rental business#1762
NeoRazorX merged 5 commits intoNeoRazorX:masterfrom
daniel89fg:3990-tipo-producto-rental-business

Conversation

@daniel89fg
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 23, 2025 07:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for a new product type "Arrendamiento local negocio" (local business rental) as part of task #3990. The changes include adding the new product type constant, expanding database field capacity, and updating asset versioning for cache busting.

  • Adds LOCAL_BUSINESS_RENTAL constant to ProductType class for rental business products
  • Increases database field size from 20 to 50 characters to accommodate longer product type names
  • Updates CSS and JavaScript asset versions for cache busting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
Core/Lib/ProductType.php Adds new LOCAL_BUSINESS_RENTAL constant and includes it in the types array
Core/Table/productos.xml Increases the 'tipo' column size from 20 to 50 characters
Core/View/Master/MicroTemplate.html.twig Updates asset versions for Bootstrap and FontAwesome resources
Core/View/Master/MenuTemplate.html.twig Updates asset versions for Bootstrap and FontAwesome resources
Comments suppressed due to low confidence (1)

Core/Lib/ProductType.php:30

  • [nitpick] The constant name LOCAL_BUSINESS_RENTAL doesn't clearly match its Spanish value 'Arrendamiento local negocio'. Consider using a more descriptive name like BUSINESS_PREMISES_RENTAL or LOCAL_RENTAL to better reflect the rental nature.
    const LOCAL_BUSINESS_RENTAL = 'Arrendamiento local negocio';

daniel89fg and others added 2 commits July 23, 2025 09:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@NeoRazorX NeoRazorX merged commit 142da99 into NeoRazorX:master Jul 23, 2025
17 checks passed
@daniel89fg daniel89fg deleted the 3990-tipo-producto-rental-business branch July 25, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants