3990 tipo producto rental business#1762
Merged
NeoRazorX merged 5 commits intoNeoRazorX:masterfrom Jul 23, 2025
Merged
Conversation
added 3 commits
June 27, 2025 11:57
…damiento local negocio' como nuevo tipo de producto
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for a new product type "Arrendamiento local negocio" (local business rental) as part of task #3990. The changes include adding the new product type constant, expanding database field capacity, and updating asset versioning for cache busting.
- Adds LOCAL_BUSINESS_RENTAL constant to ProductType class for rental business products
- Increases database field size from 20 to 50 characters to accommodate longer product type names
- Updates CSS and JavaScript asset versions for cache busting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Core/Lib/ProductType.php | Adds new LOCAL_BUSINESS_RENTAL constant and includes it in the types array |
| Core/Table/productos.xml | Increases the 'tipo' column size from 20 to 50 characters |
| Core/View/Master/MicroTemplate.html.twig | Updates asset versions for Bootstrap and FontAwesome resources |
| Core/View/Master/MenuTemplate.html.twig | Updates asset versions for Bootstrap and FontAwesome resources |
Comments suppressed due to low confidence (1)
Core/Lib/ProductType.php:30
- [nitpick] The constant name LOCAL_BUSINESS_RENTAL doesn't clearly match its Spanish value 'Arrendamiento local negocio'. Consider using a more descriptive name like BUSINESS_PREMISES_RENTAL or LOCAL_RENTAL to better reflect the rental nature.
const LOCAL_BUSINESS_RENTAL = 'Arrendamiento local negocio';
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea #3990