3990 doble factor usuario#1763
Merged
NeoRazorX merged 6 commits intoNeoRazorX:masterfrom Jul 23, 2025
Merged
Conversation
added 3 commits
June 27, 2025 11:57
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements two-factor authentication functionality for users in FacturaScripts, as indicated by the task reference #4041. The changes include upgrading the QR code library, enhancing the two-factor authentication UI, and adding proper authentication/deauthentication workflows.
- Updates the endroid/qr-code library from version ^4.3 to ^4.8 for better PHP 8.1+ compatibility
- Redesigns the two-factor authentication interface with separate states for enabled/disabled authentication
- Implements proper authentication and deauthentication actions with TOTP code validation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates endroid/qr-code dependency to version ^4.8 |
| Core/View/Tab/UserTwoFactor.html.twig | Complete redesign of 2FA UI with conditional states and improved layout |
| Core/View/Master/MicroTemplate.html.twig | Adds cache-busting version parameters to CSS/JS assets |
| Core/View/Master/MenuTemplate.html.twig | Adds cache-busting version parameters to CSS/JS assets |
| Core/Model/User.php | Removes automatic secret key generation from getTwoFactorUrl method |
| Core/Lib/TwoFactorManager.php | Adds comprehensive error handling and improves code documentation |
| Core/Controller/EditUser.php | Implements new authentication/deauthentication actions and refactors TOTP validation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea #4041
Cuando el core esté en la versión de php 8.1 en adelante, podremos cambiar la librería de QR por la que realmente usa la que usamos actualmente.