Skip to content

3990 doble factor usuario#1763

Merged
NeoRazorX merged 6 commits intoNeoRazorX:masterfrom
daniel89fg:3990-doble-factor-usuario
Jul 23, 2025
Merged

3990 doble factor usuario#1763
NeoRazorX merged 6 commits intoNeoRazorX:masterfrom
daniel89fg:3990-doble-factor-usuario

Conversation

@daniel89fg
Copy link
Copy Markdown
Contributor

Tarea #4041

Cuando el core esté en la versión de php 8.1 en adelante, podremos cambiar la librería de QR por la que realmente usa la que usamos actualmente.

Copilot AI review requested due to automatic review settings July 23, 2025 07:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements two-factor authentication functionality for users in FacturaScripts, as indicated by the task reference #4041. The changes include upgrading the QR code library, enhancing the two-factor authentication UI, and adding proper authentication/deauthentication workflows.

  • Updates the endroid/qr-code library from version ^4.3 to ^4.8 for better PHP 8.1+ compatibility
  • Redesigns the two-factor authentication interface with separate states for enabled/disabled authentication
  • Implements proper authentication and deauthentication actions with TOTP code validation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
composer.json Updates endroid/qr-code dependency to version ^4.8
Core/View/Tab/UserTwoFactor.html.twig Complete redesign of 2FA UI with conditional states and improved layout
Core/View/Master/MicroTemplate.html.twig Adds cache-busting version parameters to CSS/JS assets
Core/View/Master/MenuTemplate.html.twig Adds cache-busting version parameters to CSS/JS assets
Core/Model/User.php Removes automatic secret key generation from getTwoFactorUrl method
Core/Lib/TwoFactorManager.php Adds comprehensive error handling and improves code documentation
Core/Controller/EditUser.php Implements new authentication/deauthentication actions and refactors TOTP validation

daniel89fg and others added 3 commits July 23, 2025 09:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@NeoRazorX NeoRazorX merged commit 857a484 into NeoRazorX:master Jul 23, 2025
17 checks passed
@daniel89fg daniel89fg deleted the 3990-doble-factor-usuario branch July 25, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants