Añade función para eliminar botones en vistas#1883
Open
daniel89fg wants to merge 1 commit intoNeoRazorX:masterfrom
Open
Añade función para eliminar botones en vistas#1883daniel89fg wants to merge 1 commit intoNeoRazorX:masterfrom
daniel89fg wants to merge 1 commit intoNeoRazorX:masterfrom
Conversation
Implementa el método removeButton en BaseController para permitir la eliminación de botones específicos en las vistas. Se añaden métodos para gestionar los hijos de los botones y se asegura que se genere un hash único para cada botón.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements functionality to remove buttons from views by adding a removeButton method to BaseController. The implementation adds a hash-based identification system for buttons to enable their removal.
Changes:
- Added hash property to RowButton class for unique identification of buttons
- Implemented hash generation in RowActions.addButton using md5 of button properties (excluding action)
- Added removeButton method in BaseController to remove buttons by hash from view rows
- Added getChildren and setChildren methods to RowActions for managing button collections
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Core/Lib/Widget/RowButton.php | Added hash property and data-hash attribute to all rendered button elements |
| Core/Lib/Widget/RowActions.php | Added hash generation logic in addButton, plus getter/setter methods for children array |
| Core/Lib/ExtendedController/BaseController.php | Implemented removeButton method to find and remove buttons by hash from actions and footer rows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementa el método removeButton en BaseController para permitir la eliminación de botones específicos en las vistas. Se añaden métodos para gestionar los hijos de los botones y se asegura que se genere un hash único para cada botón.
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: