Cambiado el nombre de la columna código de los mandatos de las cuenta…#1884
Merged
NeoRazorX merged 1 commit intoNeoRazorX:masterfrom Feb 10, 2026
Merged
Cambiado el nombre de la columna código de los mandatos de las cuenta…#1884NeoRazorX merged 1 commit intoNeoRazorX:masterfrom
NeoRazorX merged 1 commit intoNeoRazorX:masterfrom
Conversation
…s bancarias de clientes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI sorting-label issue in the customer bank accounts list where the first sort option was incorrectly labeled as “mandate” while actually sorting by account code, reducing user confusion.
Changes:
- Renamed the
codcuenta(account code) sort label frombank-mandatetocodein the bank accounts view. - Updated the copyright header year in
ListCliente.php(unrelated to the functional change).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * This file is part of FacturaScripts | ||
| * Copyright (C) 2017-2025 Carlos Garcia Gomez <carlos@facturascripts.com> | ||
| * Copyright (C) 2017-2026 Carlos Garcia Gomez <carlos@facturascripts.com> |
There was a problem hiding this comment.
The copyright header year was bumped from 2025 to 2026 in this PR, but the PR purpose is about bank account sorting labels. Unless there’s a project-wide policy to update headers (usually done in a dedicated sweep), consider reverting this line to avoid unrelated diff noise/inconsistency with the rest of the codebase (many files still show 2017-2025).
Suggested change
| * Copyright (C) 2017-2026 Carlos Garcia Gomez <carlos@facturascripts.com> | |
| * Copyright (C) 2017-2025 Carlos Garcia Gomez <carlos@facturascripts.com> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s bancarias de clientes
La palabra "mandato" en la ordenación de las cuentas bancarias de los clientes esta repetido. Ya sabemos que si no se pone mandato se copia el código en el campo mandato. Pero al ordenar las cuentas bancarias, la primera opción de ordenación no es el mandato es el código, es más, la palabra mandato está repetida al final de lista de opciones de ordenación, está segunda si es correcta.
Esto hace que la gente ordene por la primera opción y vea que realmente se ordena por código, provocando confusión.
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: