Skip to content

Windows Build - fix try icon - #614

Merged
NeptuneHub merged 4 commits into
mainfrom
devel
Jun 8, 2026
Merged

Windows Build - fix try icon#614
NeptuneHub merged 4 commits into
mainfrom
devel

Conversation

@NeptuneHub

@NeptuneHub NeptuneHub commented Jun 8, 2026

Copy link
Copy Markdown
Owner

This PR is to fix the windows build, when you click directly on the .exe in the gui now the start will work properly without need the terminal start command.

PR test builds:

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a monkey-patching mechanism for pgserver's pg_ctl command on Windows to ensure it runs detached from any console and with a longer timeout, preventing startup failures when launched from a tray application. It also refactors the embedded database startup logic to only retry initialization on fresh cluster failures. The review feedback suggests making the monkey-patching thread-safe using a threading lock and improving the robustness of the wrapper when handling args, creationflags, and env arguments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread windows/db_backend.py
Comment thread windows/db_backend.py Outdated
@NeptuneHub
NeptuneHub merged commit ae6a280 into main Jun 8, 2026
21 checks passed
@NeptuneHub
NeptuneHub deleted the devel branch June 8, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant