Windows Build - fix try icon - #614
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a monkey-patching mechanism for pgserver's pg_ctl command on Windows to ensure it runs detached from any console and with a longer timeout, preventing startup failures when launched from a tray application. It also refactors the embedded database startup logic to only retry initialization on fresh cluster failures. The review feedback suggests making the monkey-patching thread-safe using a threading lock and improving the robustness of the wrapper when handling args, creationflags, and env arguments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This PR is to fix the windows build, when you click directly on the .exe in the gui now the start will work properly without need the terminal start command.
PR test builds:
ghcr.io/neptunehub/audiomuse-ai:pr-614ghcr.io/neptunehub/audiomuse-ai:pr-614-nvidiaghcr.io/neptunehub/audiomuse-ai:pr-614-noavx2