Skip to content

added CLUSTERING_CLEANING default true, if false delete the automatic… - #619

Merged
NeptuneHub merged 6 commits into
mainfrom
devel
Jun 9, 2026
Merged

added CLUSTERING_CLEANING default true, if false delete the automatic…#619
NeptuneHub merged 6 commits into
mainfrom
devel

Conversation

@NeptuneHub

@NeptuneHub NeptuneHub commented Jun 8, 2026

Copy link
Copy Markdown
Owner

This PR is to add the CLUSTERING_CLEANING parameter that:

  • by default is true, when true it delete the old cluster;
  • when false it totally skip the cleaning step.

This is related to #615

PR test builds:

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration option, CLUSTERING_CLEANING, allowing users to control whether existing automatic playlists are deleted before new clusters are created. The feedback identifies a logging contradiction in tasks/clustering.py where a log message indicating deletion is printed unconditionally, even when CLUSTERING_CLEANING is disabled and deletion is skipped. Moving this log statement inside the conditional block is recommended to ensure accurate logging.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tasks/clustering.py
Comment thread tasks/clustering_helper.py Fixed
Comment thread tasks/clustering_helper.py Fixed
Comment thread tasks/clustering_helper.py Fixed
Comment thread tasks/clustering_helper.py Dismissed
Comment thread tasks/clustering_helper.py Dismissed
Comment thread tasks/clustering_helper.py Dismissed
@NeptuneHub

Copy link
Copy Markdown
Owner Author

Functionality test and work.
Also did some round of sonar cloud and tested all the main functionality on jellyfin.

@NeptuneHub NeptuneHub closed this Jun 9, 2026
@NeptuneHub NeptuneHub reopened this Jun 9, 2026
@NeptuneHub
NeptuneHub merged commit 9c3c87b into main Jun 9, 2026
21 checks passed
@NeptuneHub
NeptuneHub deleted the devel branch June 9, 2026 12:37
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants