fix: add icons for Tuya circuit breaker#553
Conversation
There was a problem hiding this comment.
Should remove all this. We don't want to be coloring/animating basic stuff, this is never-ending, and it was rejected by users early-on anyway.
There was a problem hiding this comment.
Agreed. How should we improve lists display though?
Currently with JSON.stringify(value) they are displayed like:
["leakage_current","temperature","over_voltage"]
[]
In PR I did String(value) and $.clear
leakage_current,temperature,over_voltage
Clear
There was a problem hiding this comment.
Can't display anything when empty except something that clearly describes empty, it's too confusing ("is it a value or not?").
Also can't use anything but stringify, else it breaks nesting. We'd need something far more robust to handle nested+max depth, but the amount of work vs the amount of times this is used, I think stringify is fine for now. We can revisit when something has a clearer need, so we have a clearer picture of how it should be.
There was a problem hiding this comment.
Makes sense, thanks!
2 participants
Do you know if we can contribute icons to font awesome? Would be nice to differentiate the electrical measurements, like in HA. But we only have the two bolts
