fix: update plugin filtering logic to match exact command tag - #19464
fix: update plugin filtering logic to match exact command tag#19464alvinhui wants to merge 1 commit into
Conversation
Walkthrough调整 Changes插件过滤
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/taro-service/src/utils/index.ts`:
- Around line 134-137: Update the plugin filter in the config handling around
RelatedPluginTag to use a prefix check instead of includes, so only plugin names
equal to RelatedPluginTag or beginning with RelatedPluginTag followed by a
hyphen are retained; reject unrelated names containing that sequence elsewhere.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b0064b4e-dcda-47a9-85d6-08f83a69871c
📒 Files selected for processing (1)
packages/taro-service/src/utils/index.ts
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (55.70%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #19464 +/- ##
==========================================
+ Coverage 51.55% 55.70% +4.15%
==========================================
Files 256 451 +195
Lines 12094 23779 +11685
Branches 2847 5895 +3048
==========================================
+ Hits 6235 13247 +7012
- Misses 4844 8648 +3804
- Partials 1015 1884 +869
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
d7c0312 to
ddd9ec7
Compare
这个 PR 做了什么? (简要描述所做更改)
内部已存在部分 Plugin 包名适配
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit