Packaging improvements#109
Merged
Merged
Conversation
|
The documentation preview is available at https://preview.netcord.dev/109. |
KubaZ2
requested changes
May 22, 2025
Co-authored-by: Kuba_Z2 <77853483+KubaZ2@users.noreply.github.com>
0a31fb1 to
18b5a63
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #107, I noticed some other things I could do to improve the packages that are produced.
These changes include:
ContinuousIntegrationBuildtotruewhen building on CI. This ensures that deterministic builds are enabled.RepositoryUrlsetting in project files with the property that tells the SDK to populate the information instead. (Packaging properties like this would be a good candidate to move into Directory.Build.props)"rollForward": "latestFeature"set. I noticed that your workflow files haddotnet-version: 9.0.xin them, but it turns out that even with that set, as soon as the GitHub Actions task runners have a newer version, that version will actually get used to build regardless of what thedotnet-versionis. Adding a global.json file is only way to ensure the specified range (9.0.x) is always used.