Improve RestException logging#127
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging for REST exceptions by overriding ToString() methods and updating test exception handling to leverage the new formatting.
- Added a performant
ToString()override toRestExceptionto include error details and stack trace. - Sealed
RestErrorand added aToString()override to serialize itself. - Updated tests to catch and log exceptions via
Exception.ToString()rather than manually serializingRestError.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/NetCord.Test/Program.cs | Changed catch from RestException to Exception and replaced manual JSON logging. |
| NetCord/Rest/RestException.cs | Implemented a custom ToString() with string.Create for structured exception info. |
| NetCord/Rest/RestError.cs | Marked RestError as sealed and added a ToString() override for JSON output. |
Comments suppressed due to low confidence (1)
Tests/NetCord.Test/Program.cs:150
- Catching all exceptions here can mask unrelated errors; consider catching
RestExceptionspecifically so that other exceptions bubble up properly.
catch (Exception ex)
|
|
||
| public RestError? Error { get; } | ||
|
|
||
| public override string ToString() |
There was a problem hiding this comment.
[nitpick] This manual span-based construction is performant but complex; consider adding a comment or using a simpler StringBuilder approach if performance is not critical to improve readability and future maintenance.
|
The documentation preview is available at https://preview.netcord.dev/127. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.