Detect whether AES GCM encryption is supported before using it and fa…#364
Merged
Conversation
…llback to XChaCha20Poly1305RtpSizeEncryption if needed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates voice encryption selection to avoid using AES-256-GCM RTP size encryption on platforms where AesGcm is unsupported, falling back to XChaCha20-Poly1305 RTP size encryption when appropriate.
Changes:
- Gate AES-256-GCM selection on
AesGcm.IsSupportedvia a newIsSupportedproperty. - Introduce
IsSupportedon voice encryption implementations and add a corresponding static member onIVoiceEncryption. - Update
VoiceEncryptionProviderto conditionally choose AES-256-GCM or fall back to XChaCha20-Poly1305.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| NetCord/Gateway/Voice/VoiceEncryptionProvider.cs | Updates mode selection logic to prefer AES-GCM only when supported. |
| NetCord/Gateway/Voice/Encryption/Aes256GcmRtpSizeEncryption.cs | Adds IsSupported based on AesGcm.IsSupported. |
| NetCord/Gateway/Voice/Encryption/XChaCha20Poly1305RtpSizeEncryption.cs | Adds IsSupported (currently hardcoded). |
| NetCord/Gateway/Voice/Encryption/IVoiceEncryption.cs | Adds a static interface member for platform support detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The documentation preview is available at https://preview.netcord.dev/364. |
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llback to XChaCha20Poly1305RtpSizeEncryption if needed