Skip to content

Fixed map size error in MiniHack-MultiRoom environments#6

Merged
samvelyan merged 1 commit intoNetHack-LE:mainfrom
BartekCupial:fix/multi_room_map_generation_bug
Feb 23, 2025
Merged

Fixed map size error in MiniHack-MultiRoom environments#6
samvelyan merged 1 commit intoNetHack-LE:mainfrom
BartekCupial:fix/multi_room_map_generation_bug

Conversation

@BartekCupial
Copy link

All Submissions:

Associated issue: #5

Description

This PR fixes the map size error in MiniHack-MultiRoom environments where maps were being generated with dimensions exceeding the maximum allowed size (76x21)

Changes Made

  • Modified map generation parameters to ensure dimensions stay within the maximum allowed size
  • Updated docs to point to Farama MiniGrid
  • Moved wizkit_items to options (how it is currently handled in nle)

Testing

  • Verified environment creation works with MiniHack-MultiRoom-N6-v0
import minihack
import gymnasium as gym
env = gym.make("MiniHack-MultiRoom-N10-Lava-OpenDoor-v0")
env.reset()
env.render()

Closes #5

@github-actions github-actions bot added the envs label Feb 12, 2025
@BartekCupial BartekCupial force-pushed the fix/multi_room_map_generation_bug branch from e9b275c to 734df5e Compare February 13, 2025 08:21
@samvelyan samvelyan merged commit 3b1a31e into NetHack-LE:main Feb 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Minihack-MultiRoom map generation bug (map too large)

2 participants