Merged
Conversation
Author
|
@samvelyan can we merge this? |
samvelyan
requested changes
Feb 27, 2025
Collaborator
samvelyan
left a comment
There was a problem hiding this comment.
Hi @BartekCupial. Many thanks for the PR. This looks great. Just have a few small points:
-
In sokoban.py, could you please rename the version of the environments from
-v0to-v1, given considerable change to their dynamics. -
It would be wonderful to also update the documentation to reflect these changes.
Author
|
@samvelyan tell me if there sth more to be done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated issue: #4
Description
This PR fixes a crash in the Sokoban environments when the agent character (@) disappears from observation. The crash occurs because _object_positions() returns an empty list when the agent is not found, causing an IndexError when accessing the first element
Changes Made
agent_pos = next((pos for pos in self._object_positions(observation, "@")), None)Testing
Closes #4