Disable ttyrec recording by default in tests to avoid polluting the directory in which tests are run#105
Open
jbcoe wants to merge 1 commit intoNetHack-LE:mainfrom
Open
Disable ttyrec recording by default in tests to avoid polluting the directory in which tests are run#105jbcoe wants to merge 1 commit intoNetHack-LE:mainfrom
jbcoe wants to merge 1 commit intoNetHack-LE:mainfrom
Conversation
jbcoe
changed the title
Collaborator
|
I've just ignored the file so far! |
Author
|
If this is know about, I'll consider my investigation complete. I don't think that running tests should need write access to the working directory, this PR fixes that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, a file (
nle.ttyrec3.bz2) is written to the project root when tests are run. I'm curious as to why we've not spotted this before.Investigation in progress so leaving this as a draft for now.