Account for WIN_MESSAGE == WIN_ERR in free_window_info#44
Merged
heiner merged 1 commit intoNetHack-LE:mainfrom Feb 15, 2025
fmayer:patch-1
Merged
Account for WIN_MESSAGE == WIN_ERR in free_window_info#44heiner merged 1 commit intoNetHack-LE:mainfrom fmayer:patch-1
heiner merged 1 commit intoNetHack-LE:mainfrom
fmayer:patch-1
Conversation
In fact, it is always WIN_ERR in the caller in line 1403 This tripped UBSan's bounds checks
Collaborator
|
Note that we inherited this drastic issue from upstream NetHack https://github.com/NetHack/NetHack/blob/NetHack-3.6/win/tty/wintty.c#L1558 |
Collaborator
|
But 3.7 fixed the same issue: NetHack/NetHack@f9d7bc6 |
heiner
approved these changes
Feb 1, 2025
Author
|
Hmm, CI crashed with this: |
Collaborator
|
@StephenOman do you have any context on this? |
Collaborator
|
Not yet. Doesn't look related to this PR. Error is: gmake[2]: *** [dat/earth.lev] Segmentation fault (core dumped) |
Author
|
Can we rerun CI here? Seems like the issues was solved in #48 . |
Collaborator
|
Kicked off a CI rerun. We can merge regardless though, this change is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fact, it is always WIN_ERR in the caller in line 1403
This tripped UBSan's bounds checks