Skip to content

converter: harden API input validation for zero dims#90

Closed
j-lojek wants to merge 1 commit intoNetHack-LE:mainfrom
j-lojek:fix/pr1-converter-input-hardening
Closed

converter: harden API input validation for zero dims#90
j-lojek wants to merge 1 commit intoNetHack-LE:mainfrom
j-lojek:fix/pr1-converter-input-hardening

Conversation

@j-lojek
Copy link

@j-lojek j-lojek commented Feb 20, 2026

Summary

  • reject or in the Python wrapper and C converter constructor path
  • validate before reading in
  • add converter regression tests for scalar and zero-dimension converter construction

Bugs fixed

  • R1: crash on
  • R2: division-by-zero/FPE path when rows or cols are zero

Validation

  • built target with CMake/Ninja
  • ran Python regression script:
    • now raises
    • scalar now raises instead of crashing

@j-lojek j-lojek closed this Feb 20, 2026
@j-lojek j-lojek deleted the fix/pr1-converter-input-hardening branch February 20, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant