Skip to content

nlernd: remove hardcoded dungeon count assumptions#97

Closed
j-lojek wants to merge 1 commit intoNetHack-LE:mainfrom
j-lojek:fix/pr8-nlernd-dungeon-bounds
Closed

nlernd: remove hardcoded dungeon count assumptions#97
j-lojek wants to merge 1 commit intoNetHack-LE:mainfrom
j-lojek:fix/pr8-nlernd-dungeon-bounds

Conversation

@j-lojek
Copy link

@j-lojek j-lojek commented Feb 20, 2026

Summary

  • replace hardcoded NLE_NUM_DUNGEONS=8 with MAXDUNGEON-sized RNG state storage
  • seed all valid dungeon slots based on MAXDUNGEON
  • add explicit bounds validation for dungeon_num in swap-to-lgen/core paths

Bugs fixed

  • S6: hardcoded dungeon count in RNG state arrays

Validation

  • static validation of array sizing and guarded index usage
  • full build/test validation is blocked on GCC15 compatibility issue tracked in PR 10

@j-lojek j-lojek closed this Feb 20, 2026
@j-lojek j-lojek deleted the fix/pr8-nlernd-dungeon-bounds branch February 20, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant