Add check-dist workflow to validate the distribution code#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96ca345083
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: validate distribution code | ||
| run: | | ||
| if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then |
There was a problem hiding this comment.
The validate distribution code check only inspects git diff dist/, which ignores untracked files; this means the workflow can pass even when npm run build creates new files in dist/ (for example, a newly generated artifact) that were never committed. Because this workflow is intended to enforce that generated distribution output is fully committed, missing untracked artifacts is a correctness gap in the guard.
Useful? React with 👍 / 👎.
1 participant
No description provided.