make Time interface and the constructor which accepts it public, so that users can plug in time #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat users can plug in time implementations
|
Any update on merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numerus percentile class produces 0 until the first bucket time has elapsed. This can make writing unit tests tricky. Most unit testable libraries will have a TestClock that is used for getting the time, that can be updated for the unit test.
Making the Time interface public and the corresponding constructor will allow NumerusRollingPercentile to participate in unit tests without waiting for the bucket to elapse, provided someone has given a pluggable time implementation to the constructor.