Skip to content

Reusable buffer for backup uploading#1117

Closed
clohfink wants to merge 5 commits into
4.xfrom
reusable_buffer
Closed

Reusable buffer for backup uploading#1117
clohfink wants to merge 5 commits into
4.xfrom
reusable_buffer

Conversation

@clohfink

@clohfink clohfink commented Aug 9, 2025

Copy link
Copy Markdown
Contributor
Metric byte[] impl ByteBuffer impl Change
Throughput (ops/ms) 0.414 (+/- 0.083) 0.890 (+/- 0.058) 2.15x faster
Throughput (ops/s) 414 890 +476 ops/s
Alloc per op (B/op) 3,092,129.6 B/op 2,421.4 B/op 1277x less
Alloc per op (MiB/op) ~2.95 MiB/op ~0.0023 MiB/op ~99.92% reduction
GC alloc rate (MB/s) 1,043.3 1.76 593x less
GC count 12 1 91.7% fewer GCs
GC time (ms) 14 5 64.3% less time in GC

@clohfink
clohfink changed the base branch from 3.x to 4.x August 9, 2025 18:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@clohfink
clohfink requested a review from Copilot August 13, 2025 16:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mattl-netflix
mattl-netflix force-pushed the 4.x branch 2 times, most recently from bcb008e to 0cc0343 Compare January 30, 2026 18:09
@mattl-netflix

Copy link
Copy Markdown
Collaborator

This was committed in a later PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants