add performance tips page; java BatchUpdater coverage#269
Merged
Conversation
Net-new docs/spectator/core/performance.md collects the cross-language patterns that previously lived in a small note on core/meters/counter or were unwritten: cache the meter reference outside hot paths, build ids with createId + withTag for dynamic dimensions, pre-aggregate in tight loops, prefer basic meters over percentile variants, keep tag cardinality bounded. Adds a Java-specific subsection on BatchUpdater (Counter/Timer/DistributionSummary expose a batchUpdater(batchSize) method that buffers updates and flushes on close). Each Java meter page (counter, timer, dist-summary) gets a "Batch Updates" section; the counter page carries the annotated example and timer/dist-summary cross-reference it. Removed the now-redundant high-perf-tight-loop note from core/meters/ counter.md and replaced it with a link to the new page. Also fixed two stale links left over from the percentile merge: - java/meters/timer.md Percentile Timer section: [Timer](timer.md) -> [Timer](#timer) (self-link). - java/meters/dist-summary.md Percentile Distribution Summary section: had an orphan "concept and storage-cost caveats" fragment from where my merge script clipped a multi-line backlink. Rewrote to a single "Use a regular Distribution Summary unless..." sentence linking the in-page anchor. Nav: Performance Tips added under Core Concepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net-new docs/spectator/core/performance.md collects the cross-language patterns that previously lived in a small note on core/meters/counter or were unwritten: cache the meter reference outside hot paths, build ids with createId + withTag for dynamic dimensions, pre-aggregate in tight loops, prefer basic meters over percentile variants, keep tag cardinality bounded. Adds a Java-specific subsection on BatchUpdater (Counter/Timer/DistributionSummary expose a batchUpdater(batchSize) method that buffers updates and flushes on close).
Each Java meter page (counter, timer, dist-summary) gets a "Batch Updates" section; the counter page carries the annotated example and timer/dist-summary cross-reference it.
Removed the now-redundant high-perf-tight-loop note from core/meters/ counter.md and replaced it with a link to the new page.
Also fixed two stale links left over from the percentile merge:
Timer (self-link).
Nav: Performance Tips added under Core Concepts.