tag atlas.eval.datapoints counters with upstream host#1899
Merged
brharrington merged 2 commits intoNetflix:mainfrom Apr 21, 2026
Merged
tag atlas.eval.datapoints counters with upstream host#1899brharrington merged 2 commits intoNetflix:mainfrom
brharrington merged 2 commits intoNetflix:mainfrom
Conversation
The counters emitted by TimeGrouped and AggregatorSettings previously had no dimension identifying the upstream backend, so dropped and buffered counts from all hosts folded together. Thread the groupBy-host key from createStreamsFlow through createProcessorFlow into TimeGrouped so each counter now carries a host tag, and default AggregatorSettings host to "_" for non-host-scoped callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counters emitted by TimeGrouped and AggregatorSettings previously had no dimension identifying the upstream backend, so dropped and buffered counts from all hosts folded together. Thread the groupBy-host key from createStreamsFlow through createProcessorFlow into TimeGrouped so each counter now carries a host tag, and default AggregatorSettings host to "_" for non-host-scoped callers.