nits

Author: Alicia Matsumoto

src/dispatch/auth/permissions.py

@@ -1,5 +1,6 @@
 import logging
 from abc import ABC, abstractmethod
+import json
 
 from fastapi import HTTPException
 from starlette.requests import Request
@@ -336,7 +337,7 @@ def has_required_permissions(
         )
 
 
-class IncidentEditPermissionForTasks(BasePermission):
+class IncidentTaskCreateEditPermission(BasePermission):
     """
     Permissions dependency to apply incident edit permissions to task-based requests.
     """
@@ -346,8 +347,6 @@ def has_required_permissions(self, request: Request) -> bool:
         # for task creation, retrieve the incident id from the payload
         if request.method == "POST" and hasattr(request, "_body"):
             try:
-                import json
-
                 body = json.loads(request._body.decode())
                 incident_id = body["incident"]["id"]
             except (json.JSONDecodeError, KeyError, AttributeError):

src/dispatch/task/views.py

@@ -3,7 +3,7 @@
 
 
 from dispatch.auth.service import CurrentUser
-from dispatch.auth.permissions import PermissionsDependency, IncidentEditPermissionForTasks
+from dispatch.auth.permissions import PermissionsDependency, IncidentTaskCreateEditPermission
 from dispatch.common.utils.views import create_pydantic_include
 from dispatch.database.core import DbSession
 from dispatch.database.service import CommonParameters, search_filter_sort_paginate
@@ -48,7 +48,7 @@ def get_tasks(common: CommonParameters, include: list[str] = Query([], alias="in
     "",
     response_model=TaskRead,
     tags=["tasks"],
-    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+    dependencies=[Depends(PermissionsDependency([IncidentTaskCreateEditPermission]))],
 )
 def create_task(
     db_session: DbSession,
@@ -73,7 +73,7 @@ def create_task(
 @router.post(
     "/ticket/{task_id}",
     tags=["tasks"],
-    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+    dependencies=[Depends(PermissionsDependency([IncidentTaskCreateEditPermission]))],
 )
 def create_ticket(db_session: DbSession, task_id: PrimaryKey, current_user: CurrentUser):
     """Creates a ticket for an existing task."""
@@ -90,7 +90,7 @@ def create_ticket(db_session: DbSession, task_id: PrimaryKey, current_user: Curr
     "/{task_id}",
     response_model=TaskRead,
     tags=["tasks"],
-    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+    dependencies=[Depends(PermissionsDependency([IncidentTaskCreateEditPermission]))],
 )
 def update_task(
     db_session: DbSession, task_id: PrimaryKey, task_in: TaskUpdate, current_user: CurrentUser
@@ -122,7 +122,7 @@ def update_task(
     "/{task_id}",
     response_model=None,
     tags=["tasks"],
-    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+    dependencies=[Depends(PermissionsDependency([IncidentTaskCreateEditPermission]))],
 )
 def delete_task(db_session: DbSession, task_id: PrimaryKey, current_user: CurrentUser):
     """Deletes an existing task."""