Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@mvilanova
Copy link
Contributor

No description provided.

@mvilanova mvilanova requested review from Copilot and whitdog47 August 21, 2025 22:15
@mvilanova mvilanova self-assigned this Aug 21, 2025
@mvilanova mvilanova added the bug Something isn't working label Aug 21, 2025

This comment was marked as outdated.

@mvilanova mvilanova requested a review from Copilot August 21, 2025 22:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling for user removal operations in the Slack plugin by gracefully handling cases where users are not found in the Slack workspace. The changes ensure that user removal failures don't cause exceptions and provide better logging and user feedback.

  • Enhanced the remove_user method in the Slack plugin with comprehensive error handling for user lookup failures
  • Added graceful error handling in case and incident interactive flows when looking up users by email
  • Moved try-catch blocks to more appropriate locations in participant removal flows

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/dispatch/plugins/dispatch_slack/plugin.py Enhanced remove_user method with better error handling, logging, and documentation
src/dispatch/plugins/dispatch_slack/case/interactive.py Added error handling for user lookup failures in engage and edit functions
src/dispatch/incident/flows.py Moved try-catch block to wrap the actual remove_user call instead of plugin lookup
src/dispatch/case/flows.py Moved try-catch block to wrap the actual remove_user call instead of plugin lookup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mvilanova mvilanova merged commit bb0f4be into main Aug 25, 2025
13 checks passed
@mvilanova mvilanova deleted the fix/failed-to-remove-user branch August 25, 2025 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants