Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Aug 30, 2025

This PR adds the ability to filter cases by "security events only," which shows cases that have a dedicated channel by filtering for cases that do NOT have signal instances attached.

  • Added a new boolean filter security_event_only to the case filtering system
  • Updated the frontend UI to include a checkbox for enabling this filter
  • Modified backend filtering logic to handle the new boolean parameter
image

@whitdog47 whitdog47 requested a review from Copilot August 30, 2025 00:52
@whitdog47 whitdog47 self-assigned this Aug 30, 2025
@whitdog47 whitdog47 added the enhancement New feature or request label Aug 30, 2025
@whitdog47 whitdog47 requested a review from aaronherman August 30, 2025 00:52

This comment was marked as outdated.

@whitdog47 whitdog47 changed the title feat(ui): allow filtering by dedicated channel case feat(ui): allow filtering by dedicated channel cases Aug 30, 2025
@whitdog47 whitdog47 requested a review from Copilot August 30, 2025 00:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new filtering capability for cases to show only "security events" - cases with dedicated channels that do not have signal instances attached.

  • Added boolean filter security_event_only to frontend and backend filtering systems
  • Modified UI to include a checkbox for enabling the security events filter
  • Updated backend query logic to filter cases without signal instances using NOT EXISTS

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/dispatch/static/dispatch/src/search/utils.js Added boolean filter handling to extract and pass security_event_only parameter
src/dispatch/static/dispatch/src/router/utils.js Added boolean value processing for URL parameter handling
src/dispatch/static/dispatch/src/case/store.js Added security_event_only field to default filter state
src/dispatch/static/dispatch/src/case/TableFilterDialog.vue Added UI checkbox and state management for security events filter
src/dispatch/database/service.py Added backend parameter handling and NOT EXISTS query logic
Comments suppressed due to low confidence (1)

src/dispatch/static/dispatch/src/case/TableFilterDialog.vue:1

  • The card subtitle and checkbox hint have contradictory information. The subtitle says 'dedicated channel' while the hint says 'signal instances attached', but the backend logic filters for cases WITHOUT signal instances.
<template>

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@whitdog47 whitdog47 merged commit 2a90ae1 into main Sep 2, 2025
12 of 13 checks passed
@whitdog47 whitdog47 deleted the feat/filter-by-dedicate-channel-case branch September 2, 2025 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants