This repository was archived by the owner on Sep 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 632
feat(ui): allow filtering by dedicated channel cases #6206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new filtering capability for cases to show only "security events" - cases with dedicated channels that do not have signal instances attached.
- Added boolean filter
security_event_onlyto frontend and backend filtering systems - Modified UI to include a checkbox for enabling the security events filter
- Updated backend query logic to filter cases without signal instances using NOT EXISTS
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/dispatch/static/dispatch/src/search/utils.js | Added boolean filter handling to extract and pass security_event_only parameter |
| src/dispatch/static/dispatch/src/router/utils.js | Added boolean value processing for URL parameter handling |
| src/dispatch/static/dispatch/src/case/store.js | Added security_event_only field to default filter state |
| src/dispatch/static/dispatch/src/case/TableFilterDialog.vue | Added UI checkbox and state management for security events filter |
| src/dispatch/database/service.py | Added backend parameter handling and NOT EXISTS query logic |
Comments suppressed due to low confidence (1)
src/dispatch/static/dispatch/src/case/TableFilterDialog.vue:1
- The card subtitle and checkbox hint have contradictory information. The subtitle says 'dedicated channel' while the hint says 'signal instances attached', but the backend logic filters for cases WITHOUT signal instances.
<template>
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aaronherman
approved these changes
Sep 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to filter cases by "security events only," which shows cases that have a dedicated channel by filtering for cases that do NOT have signal instances attached.
security_event_onlyto the case filtering system