Skip to content

Replace slotId tag with clientId in PushServer #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Replace slotId tag with clientId in PushServer #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mantis-network/src/main/java/io/reactivex/mantis/network/push/PushServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,11 @@ protected Observable<Void> manageConnectionWithCompression(final DefaultChannelW
groupId = id;
}

final BasicTag slotIdTag = new BasicTag("slotId", slotId);
final BasicTag clientIdTag = new BasicTag(CLIENT_ID_TAG_NAME, Optional.ofNullable(groupId).orElse("none"));

SerializedSubject<List<byte[]>, List<byte[]>> subject
= new SerializedSubject<>(PublishSubject.<List<byte[]>>create());
Observable<List<byte[]>> observable = subject.lift(new DropOperator<>("batch_writes", slotIdTag));
Observable<List<byte[]>> observable = subject.lift(new DropOperator<>("batch_writes", clientIdTag));

if (applySampling) {
observable =
Expand All @@ -266,7 +266,6 @@ protected Observable<Void> manageConnectionWithCompression(final DefaultChannelW
);
}

final BasicTag clientIdTag = new BasicTag(CLIENT_ID_TAG_NAME, Optional.ofNullable(groupId).orElse("none"));
Metrics writableMetrics = new Metrics.Builder()
.id("PushServer", clientIdTag)
.addCounter("channelWritable")
Expand Down
Loading