Skip to content

Retry definition metadata updates for vtts updates #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
insyncoss wants to merge 1 commit into from
Closed

Retry definition metadata updates for vtts updates #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions metacat-common-server/src/main/java/com/netflix/metacat/common/server/util/MetacatUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public class MetacatUtils {

public static final String ICEBERG_MIGRATION_DO_NOT_MODIFY_TAG = "iceberg_migration_do_not_modify";
public static final String NAME_TAGS = "tags";
private static final String DATA_DEPENDENCY_NODE = "data_dependency";
private static final String VTTS_FIELD = "valid_thru_utc_ts";

/**
* Iceberg common view field names.
Expand Down Expand Up @@ -128,6 +130,21 @@ public static Set<String> getTableTags(@Nullable final ObjectNode definitionMeta
return tags;
}

public static long getVtts(final ObjectNode metadata) {
if (metadata == null) {
return -1;
}
JsonNode tmp = metadata.get(DATA_DEPENDENCY_NODE);
if (tmp == null || !tmp.isObject()) {
return -1;
}
JsonNode vttsNode = tmp.get(VTTS_FIELD);
if (vttsNode == null || !vttsNode.canConvertToLong()) {
return -1;
}
return vttsNode.asLong();
}

public static String getIcebergMigrationExceptionMsg(final String requestType,
final String tableName) {
return String.format("%s to hive table: %s are temporarily blocked " +
Expand Down
6 changes: 6 additions & 0 deletions metacat-main/src/main/java/com/netflix/metacat/main/services/impl/TableServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,12 @@ public TableDto updateAndReturn(final QualifiedName name, final TableDto tableDt
log.info("Saving user metadata for table {}", name);
final long start = registry.clock().wallTime();
userMetadataService.saveMetadata(metacatRequestContext.getUserName(), tableDto, true);
final long vtts = MetacatUtils.getVtts(tableDto.getDefinitionMetadata());
if (vtts > 0) {
log.info("Received vtts update for {} to {}", name, vtts);
userMetadataService.saveMetadata(metacatRequestContext.getUserName(), tableDto, true);
}

final long duration = registry.clock().wallTime() - start;
log.info("Time taken to save user metadata for table {} is {} ms", name, duration);
registry.timer(registry.createId(Metrics.TimerSaveTableMetadata.getMetricName()).withTags(name.parts()))
Expand Down
Loading