Fix AsyncPostgresDB initialization retry logic#440
Open
fumoboy007 wants to merge 1 commit intoNetflix:masterfrom
Open
Fix AsyncPostgresDB initialization retry logic#440fumoboy007 wants to merge 1 commit intoNetflix:masterfrom
AsyncPostgresDB initialization retry logic#440fumoboy007 wants to merge 1 commit intoNetflix:masterfrom
Conversation
saikonen
reviewed
Oct 7, 2024
Collaborator
saikonen
left a comment
saikonen
left a comment
There was a problem hiding this comment.
Thank you for the bug report and fixes.
We can go forward with the current changes as well, but at a quick glance it seemed that this could've been fixed with a smaller diff as well. Could you make the changes I noted?
| while max_attempts > 0: | ||
| try: | ||
| self.pool = await aiopg.create_pool(db_conf.get_dsn(), timeout=db_conf.timeout) | ||
| break |
Collaborator
There was a problem hiding this comment.
would it not have been sufficient to just add the break to the original code?
| break | ||
| except Exception as e: | ||
| print("printing connection exception: " + str(e)) | ||
| if retries - i < 1: |
Collaborator
There was a problem hiding this comment.
I see this is never actually hit as range excludes the end, but can be fixed with a slight tweak f.ex.
if retries-(i+1) < 1:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
Fixes #439.