Skip to content

feat: expose is_inside_foreach in DAG step info endpoint response #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vinyl-Davyl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: expose is_inside_foreach in DAG step info endpoint response #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b6f4f1
feat: exposes the `is_inside_foreach` boolean for DAG steps in endpoint
Vinyl-Davyl Mar 23, 2026
70aa66b
chore: updatted tests
Vinyl-Davyl Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/ui_backend_service/data/cache/custom_flowgraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ def node_to_dict(name, node):
"doc": node.doc,
"next": node.out_funcs,
"foreach_artifact": node.foreach_param,
"is_inside_foreach": node.is_inside_foreach,
}

def populate_block(start_name, end_name):
Expand Down Expand Up @@ -280,4 +281,4 @@ def populate_block(start_name, end_name):
steps_info["end"] = node_to_dict("end", self.nodes["end"])
graph_structure.append("end")

return steps_info, graph_structure
return steps_info, graph_structure
34 changes: 23 additions & 11 deletions services/ui_backend_service/tests/unit_tests/custom_flowgraph_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ def end(self):
"next": [
"regular_step"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
},
"regular_step": {
"name": "regular_step",
Expand All @@ -98,7 +99,8 @@ def end(self):
"prepare_foreach",
"prepare_foreach2"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
},
"prepare_foreach": {
"name": "prepare_foreach",
Expand All @@ -108,7 +110,8 @@ def end(self):
"next": [
"process_foreach"
],
"foreach_artifact": "things"
"foreach_artifact": "things",
"is_inside_foreach": False
},
"process_foreach": {
"name": "process_foreach",
Expand All @@ -118,7 +121,8 @@ def end(self):
"next": [
"join"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": True
},
"join": {
"name": "join",
Expand All @@ -128,7 +132,8 @@ def end(self):
"next": [
"ultimate_join"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
},
"prepare_foreach2": {
"name": "prepare_foreach2",
Expand All @@ -138,7 +143,8 @@ def end(self):
"next": [
"process_foreach2"
],
"foreach_artifact": "things"
"foreach_artifact": "things",
"is_inside_foreach": False
},
"process_foreach2": {
"name": "process_foreach2",
Expand All @@ -148,7 +154,8 @@ def end(self):
"next": [
"join2"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": True
},
"join2": {
"name": "join2",
Expand All @@ -158,7 +165,8 @@ def end(self):
"next": [
"after_join"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
},
"after_join": {
"name": "after_join",
Expand All @@ -168,7 +176,8 @@ def end(self):
"next": [
"ultimate_join"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
},
"ultimate_join": {
"name": "ultimate_join",
Expand All @@ -178,15 +187,17 @@ def end(self):
"next": [
"end"
],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
},
"end": {
"name": "end",
"type": "end",
"line": 65,
"doc": "",
"next": [],
"foreach_artifact": None
"foreach_artifact": None,
"is_inside_foreach": False
}
},
"graph_structure": [
Expand Down Expand Up @@ -273,3 +284,4 @@ def end(self):
pass # expect a raised exception
else:
assert False # Parsing should have failed