feat: add opt-in DBQueryTracer for per-request DB query tracing#471
Open
Youssef-SH wants to merge 2 commits intoNetflix:masterfrom
Open
feat: add opt-in DBQueryTracer for per-request DB query tracing#471Youssef-SH wants to merge 2 commits intoNetflix:masterfrom
Youssef-SH wants to merge 2 commits intoNetflix:masterfrom
Conversation
execute_sql() is the single path for all database access. This adds an opt-in tracer that records query count, rows returned, and execution time. Tracing is context-local via ContextVar, ensuring isolation per async request and avoiding global state. No overhead when tracing is disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Issue #5 by adding opt-in per-request DB query tracing in
execute_sql().All DB access flows through this method. This introduces
DBQueryTracerto record:Tracing is scoped via
ContextVar, ensuring isolation per async request.When disabled, it is a no-op (single conditional check, no overhead).
Validation
Tested on the dev stack using real endpoints:
GET /flows/TestFlow/runs
GET /flows/TestFlow/runs/3/steps/start/tasks
The first endpoint executes a single DB query.
The second demonstrates query fan-out across multiple DB calls.
Notes
execute_sql())