Skip to content

Add limit cap to prevent large payload in runs API #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rachit018 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Add limit cap to prevent large payload in runs API #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added ,
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions services/ui_backend_service/api/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ async def get_all_runs(self, request):
# due to lack of pg statistics on JSONB fields. To battle this, first execute
# subquery of ordered list from runs_v3 table in and filter by tags on outer query.
# This needs more research in the future to further improve performance.
_, limit, offset, _, _, _ = pagination_query(request)

# Prevent very large payloads
limit = min(limit, 100)
builtin_conditions, _ = builtin_conditions_query(request)
has_tag_filter = len([s for s in builtin_conditions if 'tags||system_tags' in s]) > 0
if has_tag_filter:
Expand Down