Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Metaflow UI Cloudformation nested stack support. #42

Merged
merged 7 commits into from
Oct 27, 2021

Conversation

msavela
Copy link
Contributor

@msavela msavela commented Sep 24, 2021

IMPORTANT: Do not merge before User Interface is released as part of netflixoss/metaflow_metadata_service Docker image.

Related Admin Docs PR: Netflix/metaflow-docs#12

User Interface is provided as part of the metaflow-cfn-template.yml template and doesn't require any additional
configuration besides enabling the EnableUI -parameter. You can follow the AWS CloudFormation Deployment instructions.

Once deployed the Cloudformation Stack will provide two outputs:

  • UIServiceUrl - Application Load Balancer endpoint
  • UIServiceCloudfrontUrl - Cloudfront distribution (using ALB) endpoint with HTTPS enabled (preferred)

Please note: Metaflow User Interface doesn't provide any authentication by default.

@savingoyal savingoyal requested a review from queueburt October 15, 2021 18:35
Properties:
Family: !FindInMap ["ServiceInfoUI", "ServiceName", "value"]
Cpu: !FindInMap ["ServiceInfoUI", "ContainerCpu", "value"]
Memory: !FindInMap ["ServiceInfoUI", "ContainerMemory", "value"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we configure SSDs for the cache in fargate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's possible to configure that while using Fargate.

ContainerCpu:
value: 512
ContainerMemory:
value: 1024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use higher values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is following the same configuration as metadata service. I would keep these values as is and let admin alter resources as needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but the performance profile of the UI service is quite different than the metadata service.

Type: String
Default: 'false'
AllowedValues: ['false', 'true']
Description: 'Enable Metaflow UI'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should call out that we strongly recommend deploying the UI against a logical replica of the DB and they should only enable the UI here for testing purposes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a pointer to a README on how to create a logical replica in README.md.

Copy link
Contributor Author

@msavela msavela Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin doc PR includes overview of setting up a logical replication https://github.com/Netflix/metaflow-docs/pull/12/files#diff-27c4a28d354456792c127bf0139de4d3f74a9264a4ac176e01dba0b866692240. We can refer to this document once approved and merged.

…g related to UI is now within the main template.
@msavela msavela marked this pull request as ready for review October 27, 2021 10:53
@savingoyal savingoyal merged commit 61deb95 into Netflix:master Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants