fix/artifact-copy-button-not-working #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyinglao
force-pushed
the
fix/artifact-copy-button-not-working
branch
from
3ee3d50 to
9c7f187
Compare
- Added position: relative and z-index: 1 to Modal container to fix z-index stacking - Added notification feedback when artifact code is copied to clipboard - Added mock artifacts data for testing - Added NotificationsProvider to test wrapper for notification support - Added unit test for copy button functionality
liuyinglao
force-pushed
the
fix/artifact-copy-button-not-working
branch
from
9c7f187 to
b259a19
Compare
added 2 commits
January 5, 2026 12:32
obgibson
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Description of the Change
The artifact copy button doesn't copy the text. The PR is to make it work. I also added the notification banner when copy succeed to align with the behavior of other copy button (e.g. the logs)
Alternate Designs
N/A
Possible Drawbacks
N/A
Verification Process
mock data is added to
browse.jsfor mock artifact data. and it is verified thatRelease Notes
Fixed the issue that artifact copy button doesn't copy text.