Skip to content

Commit d591bd4

Browse files
author
Nissan Pow
committed
fix: install Python dev deps via requirements-devstack.txt on tilt up
Add a local_resource that pip-installs devtools/requirements-devstack.txt so tools like localbatch are available without manual setup. The localbatch serve resource now depends on install-dev-deps so it waits for the install to complete before starting.
1 parent c8b8021 commit d591bd4

3 files changed

Lines changed: 13 additions & 5 deletions

File tree

devtools/Tiltfile

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,15 +181,22 @@ local_resource(
181181
resource_deps=config_resources,
182182
)
183183

184+
# ---------------------------------------------------------------------------
185+
# Python dev dependencies
186+
# ---------------------------------------------------------------------------
187+
local_resource(
188+
name="install-dev-deps",
189+
cmd="pip install -r devtools/requirements-devstack.txt",
190+
deps=["devtools/requirements-devstack.txt"],
191+
labels=["setup"],
192+
)
193+
184194
# ---------------------------------------------------------------------------
185195
# Test image
186196
# ---------------------------------------------------------------------------
187197
local_resource(
188198
name="build-test-image",
189-
cmd=(
190-
"docker build -t metaflow-test:python3.9 docker/metaflow-test/ && " +
191-
"minikube image load metaflow-test:python3.9"
192-
),
199+
cmd="minikube image build -t metaflow-test:python3.9 docker/metaflow-test/",
193200
deps=["docker/metaflow-test/Dockerfile"],
194201
labels=["test"],
195202
)

devtools/requirements-devstack.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
localbatch

devtools/tilt/localbatch.tiltfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def setup_localbatch(ctx):
3535
link("http://localhost:8000/docs", "localbatch API docs"),
3636
],
3737
labels=["localbatch"],
38-
resource_deps=ctx.components["localbatch"],
38+
resource_deps=ctx.components["localbatch"] + ["install-dev-deps"],
3939
)
4040

4141
return new_result(

0 commit comments

Comments
 (0)