[Ready for review] Add explicit max length control for foreach value. #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinyu
changed the title
savingoyal
requested changes
Feb 15, 2024
metaflow/flowspec.py
Outdated
| @@ -529,7 +530,7 @@ def _is_primitive_type(item): | |||
| ) | |||
|
|
|||
| value = item if _is_primitive_type(item) else reprlib.Repr().repr(item) | |||
| return basestring(value) | |||
| return basestring(value)[:MAXIMUM_VALUE_CHARACTERS] | |||
There was a problem hiding this comment.
Repr already has a default limit of 30 already - I imagine this change only affects primitives right now. I would recommend setting the value of maxstring to MAX_CHARS so that if the value of MAX_CHARS is modified in the future - you can expect a consistent response if repr is in action.
There was a problem hiding this comment.
Repr doc is ambiguous, the maxstring=30 for Repr means that the string inside the represented result is <=30 (it doesn't truncate the entire representation to maxstring. for example,
reprlib.Repr().repr({"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa": "bbbbbbbbbbbbbbbbbbbbbbb"})
"{'aaaaaaaaaaaa...aaaaaaaaaaaaa': 'bbbbbbbbbbbbbbbbbbbbbbb'}"
romain-intel
previously approved these changes
Feb 16, 2024
savingoyal
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a length control for final result as string. This will prevent us from generating a list of foreach value with crazy long value.