-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metaflow-diff to main CLI #2238
Conversation
metaflow/cmd/diff/__init__.py
Outdated
diropt = f" --directory={path.rstrip('/')}" | ||
else: | ||
diropt = "" | ||
echo("Apply the patch by running:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo and echo_always are a bit confusing here (one calls the other with some foreground, etc). Also, not sure if we want to respect the quiet flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is your suggestion? get rid of echo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
diropt = f" --directory={path.rstrip('/')}" | ||
else: | ||
diropt = "" | ||
echo("Apply the patch by running:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why one and the other? THey seem to do the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure. @tuulos ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, what's the question @romain-intel ?
Superseded by #2282 |
Had to shorten the help text to prevent it being chopped off: