[Working POC] Working commit for spin #2335
Open
+1,119
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npow
reviewed
Mar 6, 2025
| try: | ||
| spec = importlib.util.spec_from_file_location("artifacts_module", file_path) | ||
| module = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(module) |
There was a problem hiding this comment.
Seems like if there's arbitrary python code in the file, it will be executed here. Do we need to worry about that?
npow
reviewed
Mar 6, 2025
| "--spin-pathspec", | ||
| default=None, | ||
| show_default=True, | ||
| help="Task ID to use when spinning up the step. The spun step will use the artifacts" |
npow
reviewed
Mar 6, 2025
| help="Change namespace from the default (your username) to the specified tag.", | ||
| ) | ||
| @click.option( | ||
| "--skip-decorators/--no-skip-decorators", |
There was a problem hiding this comment.
maybe expose the decorator whitelist instead?
npow
reviewed
Mar 6, 2025
| module = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(module) | ||
| variables = vars(module) | ||
| return variables |
There was a problem hiding this comment.
shouldn't you check that ARTIFACTS exists here?
npow
reviewed
Mar 6, 2025
| else: | ||
| # (Current task, "A:10,B:13,C:21") and (Parent task, "A:10,B:13") | ||
| # (Current task, "A:10,B:13") and (Parent task, "A:10,B:13") | ||
| if parent_step_type == "split-foreach": |
There was a problem hiding this comment.
can we move these strings into constants?
npow
reviewed
Mar 6, 2025
| # Spin configuration | ||
| ### | ||
| SPIN_ALLOWED_DECORATORS = from_conf( | ||
| "SPIN_ALLOWED_DECORATORS", ["conda", "pypi", "environment", "titus"] |
There was a problem hiding this comment.
titus probably shouldn't be in this repo
npow
reviewed
Mar 6, 2025
| @@ -306,6 +385,40 @@ def __enter__(self) -> "Runner": | |||
| async def __aenter__(self) -> "Runner": | |||
| return self | |||
|
|
|||
| def __get_executing_task(self, attribute_file_fd, command_obj): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working version of
spin. To use it simply run the following command:You might have to run the flow once with this new commit, before being able to spin individual steps.
For instance,