fix: add jobset and argo events to devtools #3124
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| load('ext://helm_remote', 'helm_remote') | ||
| load('./_result.tiltfile', 'new_result') | ||
|
|
||
| def setup_argo_events(ctx): | ||
| helm_remote( | ||
| 'argo-events', | ||
| version=ctx.versions.argo_events_chart, | ||
| repo_name='argo', | ||
| repo_url='https://argoproj.github.io/argo-helm', | ||
| set=[ | ||
| 'crds.install=true', | ||
| 'controller.metrics.enabled=true', | ||
| 'controller.livenessProbe.initialDelaySeconds=1', | ||
| 'controller.readinessProbe.initialDelaySeconds=1', | ||
| 'controller.resources.requests.memory=64Mi', | ||
| 'controller.resources.requests.cpu=25m', | ||
| 'controller.resources.limits.memory=128Mi', | ||
| 'controller.resources.limits.cpu=50m', | ||
| 'configs.jetstream.streamConfig.maxAge=72h', | ||
| 'configs.jetstream.streamConfig.replicas=1', | ||
| 'controller.rbac.enabled=true', | ||
| 'controller.rbac.namespaced=false', | ||
| 'controller.serviceAccount.create=true', | ||
| 'controller.serviceAccount.name=argo-events-events-controller-sa', | ||
| 'configs.jetstream.versions[0].configReloaderImage=natsio/nats-server-config-reloader:latest', | ||
| 'configs.jetstream.versions[0].metricsExporterImage=natsio/prometheus-nats-exporter:latest', | ||
| 'configs.jetstream.versions[0].natsImage=nats:latest', | ||
| 'configs.jetstream.versions[0].startCommand=/nats-server', | ||
| 'configs.jetstream.versions[0].version=latest', | ||
| 'configs.jetstream.versions[1].configReloaderImage=natsio/nats-server-config-reloader:latest', | ||
| 'configs.jetstream.versions[1].metricsExporterImage=natsio/prometheus-nats-exporter:latest', | ||
| 'configs.jetstream.versions[1].natsImage=nats:2.9.15', | ||
| 'configs.jetstream.versions[1].startCommand=/nats-server', | ||
| 'configs.jetstream.versions[1].version=2.9.15', | ||
| 'global.image.tag=%s' % ctx.versions.argo_events_image, | ||
| ] | ||
| ) | ||
|
|
||
| k8s_yaml(read_file('./tilt/k8s/argo-events-rbac.yaml')) | ||
| k8s_yaml(read_file('./tilt/k8s/argo-events-eventbus.yaml')) | ||
| k8s_yaml(read_file('./tilt/k8s/argo-events-eventsource.yaml')) | ||
| k8s_yaml(read_file('./tilt/k8s/argo-events-webhook-svc.yaml')) | ||
|
|
||
| local_resource( | ||
| name='argo-events-webhook-eventsource-svc', | ||
| serve_cmd='while ! kubectl get service/argo-events-webhook-eventsource-svc-tilt >/dev/null 2>&1 || ! kubectl get pods -l eventsource-name=argo-events-webhook -o jsonpath="{.items[*].status.phase}" | grep -q "Running"; do sleep 5; done && kubectl port-forward service/argo-events-webhook-eventsource-svc-tilt 12000:12000', | ||
| links=[link('http://localhost:12000/metaflow-event', 'Argo Events Webhook')], | ||
| labels=['argo-events'], | ||
| ) | ||
|
|
||
| k8s_resource('argo-events-controller-manager', labels=['argo-events']) | ||
|
|
||
| return new_result( | ||
| config={ | ||
| "METAFLOW_ARGO_EVENTS_EVENT": "metaflow-event", | ||
| "METAFLOW_ARGO_EVENTS_EVENT_BUS": "default", | ||
| "METAFLOW_ARGO_EVENTS_EVENT_SOURCE": "argo-events-webhook", | ||
| "METAFLOW_ARGO_EVENTS_SERVICE_ACCOUNT": "operate-workflow-sa", | ||
| "METAFLOW_ARGO_EVENTS_WEBHOOK_AUTH": "service", | ||
| "METAFLOW_ARGO_EVENTS_INTERNAL_WEBHOOK_URL": "http://argo-events-webhook-eventsource-svc:12000/metaflow-event", | ||
| "METAFLOW_ARGO_EVENTS_WEBHOOK_URL": "http://localhost:12000/metaflow-event", | ||
| }, | ||
| config_resources=['argo-events-controller-manager', 'argo-events-webhook-eventsource-svc'], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| load('./_result.tiltfile', 'new_result') | ||
|
|
||
| def setup_jobset(ctx): | ||
| jobset_manifest_url = "https://github.com/kubernetes-sigs/jobset/releases/download/%s/manifests.yaml" % ctx.versions.jobset | ||
| k8s_yaml(local("curl -sSL %s" % jobset_manifest_url)) | ||
|
|
||
| k8s_resource('jobset-controller-manager', labels=['jobset']) | ||
|
|
||
| k8s_yaml(read_file('./tilt/k8s/jobset-rbac.yaml')) | ||
|
|
||
| return new_result( | ||
| config={"METAFLOW_KUBERNETES_JOBSET_ENABLED": "true"}, | ||
| config_resources=['jobset-controller-manager'], | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,17 @@ | ||||||
| apiVersion: argoproj.io/v1alpha1 | ||||||
| kind: EventBus | ||||||
| metadata: | ||||||
| name: default | ||||||
| namespace: default | ||||||
| spec: | ||||||
| jetstream: | ||||||
| version: "2.9.15" | ||||||
| replicas: 3 | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||||||
| containerTemplate: | ||||||
| resources: | ||||||
| limits: | ||||||
| cpu: 100m | ||||||
| memory: 128Mi | ||||||
| requests: | ||||||
| cpu: 100m | ||||||
| memory: 128Mi | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: EventSource | ||
| metadata: | ||
| name: argo-events-webhook | ||
| namespace: default | ||
| spec: | ||
| template: | ||
| container: | ||
| resources: | ||
| requests: | ||
| cpu: 25m | ||
| memory: 50Mi | ||
| limits: | ||
| cpu: 25m | ||
| memory: 50Mi | ||
| service: | ||
| ports: | ||
| - port: 12000 | ||
| targetPort: 12000 | ||
| webhook: | ||
| metaflow-event: | ||
| port: "12000" | ||
| endpoint: /metaflow-event | ||
| method: POST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: operate-workflow-sa | ||
| namespace: default | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| name: operate-workflow-role | ||
| namespace: default | ||
| rules: | ||
| - apiGroups: [argoproj.io] | ||
| resources: [workflows, workflowtemplates, cronworkflows, clusterworkflowtemplates] | ||
| verbs: ["*"] | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: operate-workflow-role-binding | ||
| namespace: default | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: Role | ||
| name: operate-workflow-role | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: operate-workflow-sa | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| name: view-events-role | ||
| namespace: default | ||
| rules: | ||
| - apiGroups: [argoproj.io] | ||
| resources: [eventsources, eventbuses, sensors] | ||
| verbs: [get, list, watch] | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: view-events-role-binding | ||
| namespace: default | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: Role | ||
| name: view-events-role | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: argo-workflows | ||
| namespace: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: argo-events-webhook-eventsource-svc-tilt | ||
| namespace: default | ||
| spec: | ||
| ports: | ||
| - port: 12000 | ||
| protocol: TCP | ||
| targetPort: 12000 | ||
| selector: | ||
| controller: eventsource-controller | ||
| eventsource-name: argo-events-webhook | ||
| owner-name: argo-events-webhook | ||
| type: ClusterIP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: jobset-full-access | ||
| rules: | ||
| - apiGroups: [jobset.x-k8s.io] | ||
| resources: [jobsets] | ||
| verbs: ["*"] | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: default-jobset-binding | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: default | ||
| namespace: default | ||
| roleRef: | ||
| kind: ClusterRole | ||
| name: jobset-full-access | ||
| apiGroup: rbac.authorization.k8s.io |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl -sSLdownloads the jobset manifest from GitHub at everytilt upwithout verifying its checksum. While the URL is version-pinned, an upstream compromise or MITM between the developer and GitHub would apply arbitrary manifests to the cluster. Consider caching the manifest in-tree (as done with the RBAC file) or at least documenting the known SHA so developers can verify out-of-band.