-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support matrix and contributor environment clarity #3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AshishPadala
wants to merge
7
commits into
Netflix:master
Choose a base branch
from
AshishPadala:docs-support-matrix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−0
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
abe01ef
Add support matrix and contributor environment clarity
AshishPadala 3cbad88
Fix code block formatting in Local Testing Guide
AshishPadala c2b1789
Add metadata consistency check script
AshishPadala 73d131f
Add metadata consistency check to CI workflow
AshishPadala 4b1dbf2
Align Python version support with CI matrix
AshishPadala 8bc211b
Fix metadata check to avoid false positives when fields are absent
AshishPadala 666cf05
Align R support documentation with CI coverage
AshishPadala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import configparser | ||
| import re | ||
| import sys | ||
|
|
||
|
|
||
| def read_setup_cfg(): | ||
| config = configparser.ConfigParser() | ||
| config.read("setup.cfg") | ||
|
|
||
| return { | ||
| "name": config.get("metadata", "name", fallback=None), | ||
| "version": config.get("metadata", "version", fallback=None), | ||
| } | ||
|
greptile-apps[bot] marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def read_setup_py(): | ||
| with open("setup.py", "r") as f: | ||
| content = f.read() | ||
|
|
||
| name_match = re.search(r"name\s*=\s*['\"](.+?)['\"]", content) | ||
|
|
||
| return { | ||
| "name": name_match.group(1) if name_match else None, | ||
| } | ||
|
|
||
|
|
||
| def read_version_file(): | ||
| with open("metaflow/version.py", "r") as f: | ||
| line = f.read().splitlines()[0] | ||
|
|
||
| version = line.split("=")[1].strip(" \"'") | ||
| return version | ||
|
|
||
|
|
||
| def main(): | ||
| cfg = read_setup_cfg() | ||
| py = read_setup_py() | ||
| version = read_version_file() | ||
|
|
||
| errors = [] | ||
|
|
||
| # Compare package name | ||
| if cfg["name"] and py["name"] and cfg["name"] != py["name"]: | ||
| errors.append( | ||
| f"Name mismatch: setup.cfg='{cfg['name']}' vs setup.py='{py['name']}'" | ||
| ) | ||
|
|
||
| # Compare version | ||
| if cfg["version"] and version and cfg["version"] != version: | ||
| errors.append( | ||
| f"Version mismatch: setup.cfg='{cfg['version']}' vs version.py='{version}'" | ||
| ) | ||
|
|
||
| if errors: | ||
| print(" Metadata consistency check FAILED:\n") | ||
| for err in errors: | ||
| print(f"- {err}") | ||
| sys.exit(1) | ||
|
|
||
| print(" Metadata consistency check PASSED") | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.