Fix #2981: Add Windows platform guard for SIGALRM in timeout_decorator and card_cli#3144
Fix #2981: Add Windows platform guard for SIGALRM in timeout_decorator and card_cli#3144k-kj0 wants to merge 4 commits intoNetflix:masterfrom
Conversation
Greptile SummaryThis PR adds Confidence Score: 5/5This PR is safe to merge — it adds simple, correct Windows guards with no logic changes to existing POSIX paths. Both files have correct module-level imports, proper indentation, and the guard fires before any SIGALRM call. The task execution flow confirms No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "Update card_cli.py" | Re-trigger Greptile |
Fixes #2981
Added sys.platform == "win32" guards to:
Both files used signal.SIGALRM which is POSIX-only and crashes on Windows.
This implements Option B from the issue: a clear early error instead of a
cryptic AttributeError mid-run.