Skip to content

Migrate to commons-lang3 #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate to commons-lang3 #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72eb13a
migrate to commons-lang3
jguerra Sep 30, 2025
cc8a7f8
Bump validation action
jguerra Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle-wrapper-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/wrapper-validation-action@v3
1 change: 0 additions & 1 deletion ribbon-archaius/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ dependencies {
api 'com.google.code.findbugs:annotations:2.0.0'
api "com.google.guava:guava:${guava_version}"
api 'commons-configuration:commons-configuration:1.8'
api 'commons-lang:commons-lang:2.6'
api "com.netflix.archaius:archaius-core:${archaius_version}"

api project(':ribbon-core')
Expand Down
2 changes: 1 addition & 1 deletion ribbon-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ dependencies {
api "org.slf4j:slf4j-api:${slf4j_version}"
api 'com.google.code.findbugs:annotations:2.0.0'
api "com.google.guava:guava:${guava_version}"
api 'commons-lang:commons-lang:2.6'
api 'org.apache.commons:commons-lang3:3.19.0'

testImplementation 'junit:junit:4.11'
testImplementation "org.slf4j:slf4j-log4j12:${slf4j_version}"
Expand Down
2 changes: 1 addition & 1 deletion ribbon-core/src/main/java/com/netflix/client/config/ReloadableClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.netflix.client.config;

import com.google.common.base.Preconditions;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
2 changes: 1 addition & 1 deletion ribbon-core/src/main/java/com/netflix/client/ssl/URLSslContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import java.security.NoSuchAlgorithmException;
import java.security.cert.CertificateException;

import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
2 changes: 1 addition & 1 deletion ribbon-loadbalancer/src/main/java/com/netflix/loadbalancer/LoadBalancerContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import com.netflix.servo.monitor.Monitors;
import com.netflix.servo.monitor.Timer;
import com.netflix.util.Pair;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
Loading