Optimize meter Id tag storage#125
Draft
fvallenilla wants to merge 1 commit intopr/line-protocol-builderfrom
Draft
Optimize meter Id tag storage#125fvallenilla wants to merge 1 commit intopr/line-protocol-builderfrom
fvallenilla wants to merge 1 commit intopr/line-protocol-builderfrom
Conversation
Store Id tags as ordered pairs so repeated Id construction and cloning do less work while preserving the line-protocol and builder improvements from the base branch. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Idtags as ordered pairs instead of copying maps through each clone pathWithTag/WithTagscheaper on topIdtests for clone, upsert, sorted, andtoMapbehaviorBenchmark results
Baseline: #124
Test plan
go test ./spectator/metergo test ./spectator/meter -run '^$' -bench 'BenchmarkCounterAddCombined$|BenchmarkCounterAddCombinedPostGC$' -benchmem -count=10Made with Cursor